The condescending part is that the reviewer understood how the method worked, bu... | Hacker News

Hacker Newsnew | past | comments | ask | show | jobs | submit

		verzeichnis on Feb 5, 2023 \| parent \| context \| favorite \| on: Don’t teach during code reviews The condescending part is that the reviewer understood how the method worked, but asked to have it explained to them again anyhow. That is dishonest. That is why the suggested rephrasing was to say: I had a hard time understanding how the method worked. How about renaming it?

nonethewiser on Feb 6, 2023 [–]

I agree. And it can be good to rephrase your opinion into a question sometimes. You may think it should be done differently but it's good to know the reasoning behind things.

But if it's the simple renaming example then by all means lead with the suggestion.

Guidelines | FAQ | Lists | API | Security | Legal | Apply to YC | Contact